Optimize rating initialization #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Askaholic
force-pushed
the
optimize-rating-initialization
branch
from
66a6afa
to
418b331
Compare
BlackYps
reviewed
Sep 23, 2021
| Determine if a player should see this game in their games list. | ||
|
|
||
| Note: This is a *hot* function, it can have significant impacts on | ||
| performance. |
There was a problem hiding this comment.
Is it because of the rating initialization? It doesn't become clear, why this comment on performance is here.
There was a problem hiding this comment.
It’s there because this is now the second time I’ve had to optimize something that was added to that function because it showed up in the profiler.
|
|
||
| chained_ratings["global"] = (1000, 50) | ||
|
|
||
| assert chained_ratings["tmm_2v2"] == chained_ratings["tmm_2v2"] |
There was a problem hiding this comment.
Is this a typo? How will this ever fail?
There was a problem hiding this comment.
This checks that the rating is cached and not recomputed. If it were recomputed we would get different mock objects for the two calls.
BlackYps
approved these changes
Sep 23, 2021
Askaholic
force-pushed
the
optimize-rating-initialization
branch
from
418b331
to
d51f11f
Compare
This should significantly reduce calls to rating initialization code
Askaholic
force-pushed
the
optimize-rating-initialization
branch
from
d51f11f
to
4828ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at the server profile generated after the last update, and it looks like the rating initialization was being called an excessive amount. This is mostly because it gets invoked both when generating
game_infoas well asplayer_infomessages.In the
game_infomessages it would be called even if the rating data wasn't actually needed, just because it had been easier to write that ways. Now, it checks whether rating enforcement is enabled first and only queries the rating if it is. I also added some caching to the rating computation itself so that the queries generated by theplayer_infomessage creation will now short circuit the majority of the time.