Fix tests trying to contact the real hydra server #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheikah45
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Ah okay I see there was a race condition in terms of the oauth service initialization vs when the first update of the public keys happens.
Although I am confused as to how that happened since the initialization should have only happened after the jwk path was mocked. And I would think that would cause all the tests to fail even if the server wasn't done as it would have different jwks than the one the test cases are signed with.
But overall changes look good, but confused as to why it was flaky in the first place.
|
It's only flaky in that one test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the cause of some flaky tests when the server went down.