Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metaclass for service creation #785

Merged
merged 1 commit into from
May 3, 2021
Merged

Remove metaclass for service creation #785

merged 1 commit into from
May 3, 2021

Conversation

Askaholic
Copy link
Collaborator

Cherry picked from #671. Want this for the renaming feature in the OAuth PR.

@Askaholic
Use __init__subclass__ instead of a metaclass for service registration
593a58b 
This syntax is a lot nicer and even makes adding keyword arguments 
really easy.
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #785 (593a58b) into develop (4d81156) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
server/core/service.py 100.00% <100.00%> (ø)
server/protocol/gpgnet.py 90.00% <0.00%> (-5.00%) ⬇️
server/gameconnection.py 94.30% <0.00%> (-0.72%) ⬇️

eoinnoble
eoinnoble approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@eoinnoble eoinnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Askaholic Askaholic merged commit 5dba1f9 into FAForever:develop May 3, 2021
@Askaholic Askaholic deleted the remove-service-meta branch May 3, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoinnoble eoinnoble eoinnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Askaholic @eoinnoble