Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#769 nightly test run #781

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

Askaholic
Copy link
Collaborator

@Askaholic Askaholic commented Apr 23, 2021

Run hypothesis tests with 10,000 examples once per day. Caches the hypothesis example database so that falsifying examples found on one test run will be tried on subsequent runs.

This means the nightly test run should essentially be gathering examples of edge cases that will then be tried on normal PR's, making the normal PR runs more effective.

Closes #769

The nightly run should not report coverage since it runs only a subset 
of tests.
Ensures we don't use the player_info message from earlier
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #781 (0e4f21f) into develop (ef0b308) will not change coverage.
The diff coverage is n/a.

@Askaholic
Copy link
Collaborator Author

I could also make the nightly test run a separate action, but then I'd have to copy over a lot of setup code so I wasn't sure if that was the right approach. On the other hand using the if conditions feels kindof dirty too.

Copy link
Contributor

@0x647262 0x647262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Askaholic Askaholic merged commit 4d81156 into FAForever:develop Apr 29, 2021
@Askaholic Askaholic deleted the issue/#769-nightly-test-run branch April 29, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightly test run to GitHub Actions
2 participants