Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control server integration tests #770

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

Askaholic
Copy link
Collaborator

@Askaholic Askaholic commented Apr 10, 2021

The control server seems to be unable to bind to the default address on github actions?

I guess it's primarily an issue of host name resolution not returning the correct address in github actions ubuntu VM's. So at least in theory binding directly to 127.0.0.1 should solve the issue by avoiding name resolution entirely.

#772

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@74f6fa0). Click here to learn what that means.
The diff coverage is 97.36%.

Impacted Files Coverage Δ
server/gameconnection.py 95.03% <96.87%> (ø)
server/games/coop.py 100.00% <100.00%> (ø)
server/games/game.py 95.55% <100.00%> (ø)
server/games/typedefs.py 98.07% <100.00%> (ø)

@Askaholic Askaholic merged commit 12d42e3 into FAForever:develop Apr 17, 2021
@Askaholic Askaholic deleted the control-server-tests branch April 17, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant