Issue/#707 fix disconnect handlers not always triggering #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
issue/#707-logout-cleanup-functions
branch
from
e922e18
to
32aa191
Compare
cleborys
approved these changes
Feb 1, 2021
|
|
||
|
|
||
| @fast_forward(30) | ||
| async def test_party_cleanup_on_abort(lobby_server): |
There was a problem hiding this comment.
What is the implicit "assert" here? If it's not properly cleaned up then the second time the start command for tmm fails and waiting for search_info times out?
There was a problem hiding this comment.
Yep exactly. If the party isn't cleaned up, then you'd get a notice message instead of search_info.
I think I should also specify that state="start" in the search_info message.
Askaholic
force-pushed
the
issue/#707-logout-cleanup-functions
branch
from
32aa191
to
f3466ab
Compare
This enforces consistency accross all disconnect handlers and allows the ServerContext to ensure that every disconnect handler is called.
Askaholic
force-pushed
the
issue/#707-logout-cleanup-functions
branch
from
f3466ab
to
85f2482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's slightly more meaty than my recent PR's :)
I refactored
on_connection_lostso it is triggered fromServerContextfor all services whenever a connection closes or is forcibly closed. It seems like there was some cleanup code that was duplicated inLobbyConnection.abortandLobbyConnection.on_connection_lostwhich had gotten out of sync at some point meaning that if a player's connection was closed viaabort, then the disconnect logic inLadderServiceandPartyServicewould not be triggered. This was causing some oldPlayerobjects to outlive theirLobbyConnection's and causing theself.player is not party.ownercheck to fail. Therefore, I've also refactored that check to use==comparison instead ofis.Closes #707