Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct rating type when choosing a map pool #702

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

Askaholic
Copy link
Collaborator

The map pool selection was still hardcoded to use ladder rating, I must have missed this spot when switching to getting the rating type from the queue.

Copy link
Member

@cleborys cleborys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably did this already, but I quickly checked that all further occurrences of RatingType.LADDER_1V1 in the code look as intended👍

@Askaholic
Copy link
Collaborator Author

Cool, yea I did another search through the project for the hardcoded uses as well.

Copy link
Contributor

@0x647262 0x647262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Askaholic Askaholic merged commit 0377e98 into FAForever:develop Jan 12, 2021
@Askaholic Askaholic deleted the mappool-selection-rating branch January 12, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants