Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#691 prevent joining a party while it is queued #698

Merged

Conversation

Askaholic
Copy link
Collaborator

For now I'm still using the ClientError copout, but I have been thinking about ways to do it better in a future PR.

Fixes #691

@Askaholic Askaholic force-pushed the issue/#691-join-party-while-searching branch from 38e4421 to e7f316f Compare December 29, 2020 01:05
Copy link
Contributor

@0x647262 0x647262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Askaholic Askaholic force-pushed the issue/#691-join-party-while-searching branch from e7f316f to 6fccd83 Compare January 4, 2021 03:44
@Askaholic Askaholic merged commit ca93108 into FAForever:develop Jan 11, 2021
@Askaholic Askaholic deleted the issue/#691-join-party-while-searching branch January 11, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TMM: Don't let players join a party while the party owner is searching
2 participants