Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only ascii characters in game names #672

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

Askaholic
Copy link
Collaborator

@Askaholic Askaholic commented Sep 26, 2020

Previously it was possible to put non-ascii characters into the game name by changing the name through the in-game lobby. These changes prevent the game name from being set to non-ascii characters from everywhere.

@Askaholic Askaholic changed the title Allow all utf8 characters in game names Allow only ascii characters in game names Sep 27, 2020
@0x647262
Copy link
Contributor

0x647262 commented Oct 9, 2020

Unit tests pass, and the code is clean.

LGTM!

Copy link
Member

@cleborys cleborys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Askaholic Askaholic force-pushed the develop branch 25 times, most recently from 375e7a6 to 6df79ac Compare December 28, 2020 05:12
@Askaholic Askaholic merged commit 3ce7261 into FAForever:develop Jan 4, 2021
@Askaholic Askaholic deleted the utf8-game-names branch January 4, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants