Game Rating: Clean up some formatting and faulty logic that I missed before #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
changed the title
norraxx
approved these changes
Jan 25, 2020
server/games/game.py
Outdated
| @@ -410,7 +409,7 @@ def host_left_lobby() -> bool: | |||
| return | |||
| if self.state != GameState.LIVE: | |||
| return | |||
| if len([ conn for conn in self._connections.values() if not conn.finished_sim ]) > 0: | |||
| if len([conn for conn in self.connections if not conn.finished_sim]) > 0: | |||
There was a problem hiding this comment.
btw: for such checks is good any(iterable)
There was a problem hiding this comment.
Good point. In this case it can even be if list:
|
ok |
Askaholic
force-pushed
the
game-rating-cleanup
branch
from
f0df6a9
to
fb39c43
Compare
Brutus5000
pushed a commit
that referenced
this pull request
Jan 27, 2020
…before (#519) * Clean up some formatting and faulty logic that I missed before * Simplify ended check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I've spent some more time analysing game results, I realized that our game rating consistency checks were not quite right. Each army should have a consistent result reported (e.g. each player reports that army 1 was defeated) but each player on a team will not necessarily have the same game result. For instance if a player dies, but their teammates still carry them to victory, then the winning team will have at least one player with a
defeatresult and at least one player with avictoryresult. For this reason,victoryresults take precedence over all other results.I also snuck in some other refactors like fixing functions that didn't exist or using
isoperator for numeric comparison instead of==. All things that I missed when reading the code on github, but my linter caught easily.