Let client do localization for Close FA message #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The notice message is not supposed to have an initiator field. |
|
Should I make it a new command? Like |
Askaholic
force-pushed
the
issue/#444-localize-closefa
branch
from
0fc6e4d
to
9d40969
Compare
|
I don't think it's needed. |
Brutus5000
pushed a commit
that referenced
this pull request
Jan 27, 2020
* Let client do the localization * Use command 'notice' to minimize client code changes, let client localize 'kick' also * Adjust tests * Remove initiator field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since client work is being done on this anyways, might as well do it right. See FAForever/downlords-faf-client#1472
Related to #444.
Closes #499.