Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Game.compute_rating #496

Merged
merged 10 commits into from
Jan 17, 2020
Merged

Refactor Game.compute_rating #496

merged 10 commits into from
Jan 17, 2020

Commits on Jan 9, 2020

  1. failing test for issue 485 bug

    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    a056ee4 View commit details
    Browse the repository at this point in the history

  2. First refactor of compute_rating. Does not handle games with results … 

    …reported UNKNOWN.
    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    18a26b7 View commit details
    Browse the repository at this point in the history

  3. compute_rating moved to GameRater class

    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    3c0fdb2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-Authored-By: Askaholic <askaholic907@gmail.com>
    @cleborys @Askaholic
    cleborys and Askaholic committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    c0aebf7 View commit details
    Browse the repository at this point in the history

  5. Add double victory test, make FFA_TEAM constant 

    use == for int identity, remove duplicate test

reformat using yapf

clean up yapf formatting hiccups
    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    80bda30 View commit details
    Browse the repository at this point in the history

  6. Treat game as draw if both parties report defeat

    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    3e4f8d6 View commit details
    Browse the repository at this point in the history

  7. yapf cleanup and a few naming refactors

    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    22dae1a View commit details
    Browse the repository at this point in the history

  8. suggested use of player_factory

    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    2734a5d View commit details
    Browse the repository at this point in the history

  9. review suggestions

    @cleborys
    cleborys committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    2c46e4a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Merge branch 'develop' into trueskill-ranks

    @Askaholic
    Askaholic authored Jan 12, 2020
    Configuration menu
    Copy the full SHA
    8d3b37f View commit details
    Browse the repository at this point in the history