Install aiomysql from git and re-enable warnings #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
install-aiomysql-from-git
branch
from
f7f7e81
to
18ee9df
Compare
|
What do you miss in aiomysql, that is needed for you? |
|
Do you know, that you can uninstall things that aren't used in production? For example git? |
|
Look at the PR I linked. It generates hundreds of warnings from inside aiomysql that make it very hard to find warnings that actually are caused by our code |
|
Lol! Np :-) |
Askaholic
force-pushed
the
install-aiomysql-from-git
branch
from
18ee9df
to
ed0a0ce
Compare
Brutus5000
pushed a commit
that referenced
this pull request
Jan 27, 2020
* Install aiomysql from git and re-enable warnings * Add git to dockerfile dependencies * Update dependencies to latest versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted a PR to
aiomysqlto fix the deprecation warnings aio-libs/aiomysql#403 which was merged, but hasn't been deployed as apparently the people with the ability to do so have disappeared into the void. So instead, we can just install from git to get the latest version