Match newbies randomly #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1) * Matchmaking graph only to include preferred match edges where the match is actually possible as determined by matches_with. _rank_partners still runs in O(n + SM_NUM_TO_RANK log n) but now requires O(n) space, with n the number of total searches. * typo * adjusting deviation and rating in test_rank_all unit test such that all matches become possible * add test for rank_all not including unmatchable games * Dostya test user in test_server_ban integration test now expected to be banned for 980 years, not 981 * tests on reasonable matchmaking thresholds * determine base minimum threshold for acceptable matches as 80% of quality of a game against yourself * increase new player threshold boundary * test that matchmaker gives high quality games to plawers with low deviation and games of any quality to new players with uncertain rating * adjust values for base rank_all test so that players are matchable * unit test typos * fixed preference order of test_rank_all
…yers and low-dev with low-dev if all share the same mean
|
I'm delighted you're working on this |
Askaholic
requested changes
Sep 3, 2019
There was a problem hiding this comment.
Yea, this will be great. We should try to get this out soon since FTX is reinstating some sort of ladder league system.
As I mentioned in one of the comments, I think there should be a heuristic for matching new players against non-new players to prevent them from getting matched against top pros. See issue #427 which was opened a while ago in regard to poor match quality for new players.
Co-Authored-By: Askaholic <askaholic907@gmail.com>
…nto match-newbies-randomly
Askaholic
reviewed
Sep 4, 2019
* rename 2500 rated player to top_player * refactor matchmaker * adapt tests to new interface for matchmaking policies * add test that Random Matching produces symmetric outputs * correct type annotations for MatchmakingPolicies .find methods * test for matchmaker class * remove __repr__ method of search
|
I'll give YAPF a try! Normally I use |
Co-Authored-By: Askaholic <askaholic907@gmail.com>
Askaholic
reviewed
Sep 5, 2019
|
I haven't heard of d = dict(item1=value1, item2=value2)into this d = {
"item1": value1,
"item2": value2
}But unfortunately yapf doesn't mess with the token stream. Looks like black does a few things like replacing string literals that use quotes with double quote versions (which I think would be super nice because I always find myself being indecisive over which type of quote to use) so I'll give it a shot. |
Brutus5000
pushed a commit
that referenced
this pull request
Jan 27, 2020
* Fix players with high rating deviations not getting 1v1 ladder matches (#1) * Matchmaking graph only to include preferred match edges where the match is actually possible as determined by matches_with. _rank_partners still runs in O(n + SM_NUM_TO_RANK log n) but now requires O(n) space, with n the number of total searches. * typo * adjusting deviation and rating in test_rank_all unit test such that all matches become possible * add test for rank_all not including unmatchable games * Dostya test user in test_server_ban integration test now expected to be banned for 980 years, not 981 * tests on reasonable matchmaking thresholds * determine base minimum threshold for acceptable matches as 80% of quality of a game against yourself * increase new player threshold boundary * test that matchmaker gives high quality games to plawers with low deviation and games of any quality to new players with uncertain rating * adjust values for base rank_all test so that players are matchable * unit test typos * fixed preference order of test_rank_all * remove now irrelevant check whether match is acceptable in StableMarriage.find * use filter in _rank_partners * added test for whether high-dev players are matched with high-dev players and low-dev with low-dev if all share the same mean * added sanity checks for game quality thresholds of two-player search parties * remove mocker, loop fixtures from matchmaker_queue tests * tests for identifying single newbies * methods for identifying single newbies * removed more mocker, loop fixtures * make is_ladder_newbie (actually) static * tests for forcefully matching newbies * forcefully matching unmatched newbies after stable marriage * Typos (#4) Typos * suggestions from code review Co-Authored-By: Askaholic <askaholic907@gmail.com> * suggested changes from PR review * tests for not forcefully matching singles with teams * only matching with single searches * typos * will never force match players with rating above config.TOP_PLAYER_MIN_RATING = 2000 * rename 2500 rated player to top_player * Refactor stable marriage (#5) * rename 2500 rated player to top_player * refactor matchmaker * adapt tests to new interface for matchmaking policies * add test that Random Matching produces symmetric outputs * correct type annotations for MatchmakingPolicies .find methods * test for matchmaker class * remove __repr__ method of search * refactor building the matchmaking graph for stable marriage * package building the matchmaking graph into a class * added logging to MatchingGraph * removed print statement from tests * style suggestions from code review Co-Authored-By: Askaholic <askaholic907@gmail.com> * yapf reformat on algorithm.py * set forcematch rating cutoff default to 1600 * adapt test numbers to new forcematch default * adapt tests to multiple ratings * slight debug message improvement * matchmaking policy logs invoking class, Matchmaker logs which algorithms are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested: match newbie players randomly if the stable marriage didn't match them.
Prefers to match two unmatched newbies with each other before matching with a "normal" player.