Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only tell authenticated clients about matchmaker info #466

Merged
merged 4 commits into from
Jul 17, 2019
Merged

Only tell authenticated clients about matchmaker info #466

merged 4 commits into from
Jul 17, 2019

Conversation

Askaholic
Copy link
Collaborator

Closes #465

@Askaholic Askaholic force-pushed the issue/#465-unauthenticated-matchmaker-info branch from 353a9dd to f465d82 Compare July 14, 2019 08:09
@Askaholic Askaholic requested a review from Rackover July 15, 2019 19:00
Rackover
Rackover reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@Rackover Rackover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand the kwarg removal

tests/integration_tests/test_matchmaker.py Show resolved Hide resolved
tests/integration_tests/test_server.py Show resolved Hide resolved
@Rackover
Copy link
Member

Mergeable as soon as tested

@Askaholic Askaholic merged commit 27083c4 into FAForever:develop Jul 17, 2019
@Askaholic Askaholic deleted the issue/#465-unauthenticated-matchmaker-info branch July 17, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rackover Rackover Rackover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server reports matchmaker_info to unauthenticated connections
2 participants
@Askaholic @Rackover