Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ban duration SECOND setting on closeLobby #443

Merged
merged 13 commits into from
Jul 14, 2019
Merged

Added ban duration SECOND setting on closeLobby #443

merged 13 commits into from
Jul 14, 2019

Conversation

Rackover
Copy link
Member

@Rackover Rackover commented Jun 5, 2019

Untested yet

Askaholic
Askaholic requested changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@Askaholic Askaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better

server/lobbyconnection.py Outdated Show resolved Hide resolved
server/lobbyconnection.py Show resolved Hide resolved
tests/unit_tests/test_lobbyconnection.py Outdated Show resolved Hide resolved
tests/unit_tests/test_lobbyconnection.py Outdated Show resolved Hide resolved
server/lobbyconnection.py Outdated Show resolved Hide resolved
Askaholic
Askaholic approved these changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@Askaholic Askaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Askaholic Askaholic merged commit 613f155 into develop Jul 14, 2019
@Brutus5000 Brutus5000 deleted the ban_duration branch February 29, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Askaholic Askaholic Askaholic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rackover @Askaholic