-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OAuth2 authentication with aiohttp to prevent blocking #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apart from that, it's working. |
This actually uncovered a bug which prevented fradulent logins from receiving an auto-ban
Brutus5000
pushed a commit
that referenced
this pull request
Jun 24, 2019
* Implement oauth2 using aiohttp * Connect to policy server using aiohttp not requests * Modify ApiAccessor for aiohttp response objects * Use .startswith for https check * Test that missing tokens are checked * Add test for SessionManager * Add error handling in event and achievemnt service * Add tests for Oauth2Session * Add tests for more error conditions * Let pytest handle skiping slow tests * Replace call to deprecated aiohttp api * Add test for policy server connection code * Use `async with` for aiohttp session * Add more tests for check_policy_conformity This actually uncovered a bug which prevented fradulent logins from receiving an auto-ban * Add test for player signing in from two machines at the same time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409
Closes #404
Closes #406
Closes #402
Tested this on the test server and it appears to work correctly. The server continues to print debug info while the API request is happening. Would like to test it with more people though.