Issue/#970 Prevent queue pop timer from becoming negative#1014
Merged
Askaholic merged 2 commits intoFAForever:developfrom Apr 21, 2024
Merged
Issue/#970 Prevent queue pop timer from becoming negative#1014Askaholic merged 2 commits intoFAForever:developfrom
Askaholic merged 2 commits intoFAForever:developfrom
Conversation
Sheikah45
approved these changes
Apr 20, 2024
Collaborator
|
Is five seconds enough to allow recovery of the timer or will it stay stuck on the five seconds? |
Collaborator
Author
|
Good question. I think it depends on how many players are in the queue. If the number of players in the queue stays the same or increases then the timer will continue to be stuck at the minimum. I’m not sure what that number has to be though. |
Collaborator
|
15 seconds sounds like a reasonable minimum to me, even if it stays stuck at this for some time. |
Collaborator
Author
|
Fine with me |
Askaholic
force-pushed
the
issue/#970-negative-pop-timer
branch
from
a4fffdc to
dde9b46
Compare
Askaholic
force-pushed
the
issue/#970-negative-pop-timer
branch
from
dde9b46 to
cae8998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a quick fix to prevent the timer from going negative by adding a minimum pop time to the config as well. Ideally the queue rate calculation should be fixed as well in a separate PR.
Closes #970