Command game_join allows foed players to join
#778
Labels
Comments
Askaholic
pushed a commit
that referenced
this issue
Jun 3, 2021
* Fix for foes in command_game_join Adds a check for a player joining the game to see if they are foed with the host of the game. This is my first attempt at solving an issue so if i fucked up please bear with me. * added a client error for game_join added a client error when a player on the hosts foe list tries joining the game. * changed error message and moved the check down * removed old code * changed self.game_service[uuid] to game * Added a test to confirm the check works * Fixed steam id for foed player test * Fixed issues with tests mostly caused by test not being foed with dostya anymore * Fixed syntax and removed unused code. Also changed some lobbyconnection tests. * Fixed more spacing issues * Fixed another spacing issue * Removed unused variables and added new line at the end of lobbyconnection * Fixed test_command_game_host.* tests having the wrong lobbyconnection.player. Also removed unneeded in_game variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There should really be a check for foed players in
LobbyConnection.command_game_joinsimilar to the check that exists when sending party invites here:server/server/lobbyconnection.py
Lines 1056 to 1057 in 4dd4c92
It is currently possible to join games of players who have foed you because of another bug that allows you to see those games when logging in (see #777). Regardless, game_join should still check for foes to be fully correct.
The text was updated successfully, but these errors were encountered: