You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Anything that's not defeat, victory, or draw should be completely ignored by the game results logic. Right now score actually means number of kills that the player got, but it interferes with some of the other legacy rating logic (sum of scores) causing rating bugs.
* Add tests for draw bug
* Refactor GameOutcome enum into several enums
We can now distinguish between results in their various stages:
1. Results reported by an individual for a specific army
2. Accepted result for an army based on the individual reports
3. Accepted result for the whole team based on the accepted army results
For instance, it doesn't make sense for a player's game to report the
status
of a particular result as "conflicting" since conflicts only arise when
multiple players report different results for the same army. The Enum's
now
reflect that, and you can no longer report a "conflicting" or "unknown"
result directly (as you could have before).
As a consequence, any result string that is not present in the
ArmyReportedOutcome will be ignored. Hence, the ACU kills reported via
"score"
results will no longer affect the army score calculation (previously
these
could turn a -10 score from a defeat into a positive number if the
player got
any acu kills).
Anything that's not
defeat
,victory
, ordraw
should be completely ignored by the game results logic. Right nowscore
actually means number of kills that the player got, but it interferes with some of the other legacy rating logic (sum of scores) causing rating bugs.I think we change this line:
server/server/games/game.py
Lines 288 to 291 in 8d95f77
to
The text was updated successfully, but these errors were encountered: