#658 - ensure rowcount is not empty (#688)

* #658 - ensure rowcount is not empty * #658 - base on review comments * #658 - fix codacy issues * #658 - add id to logging
FAForever · Jan 4, 2021 · 2621783 · 2621783
1 parent bab13c2
commit 2621783
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/server/rating_service/rating_service.py b/server/rating_service/rating_service.py
@@ -283,7 +283,11 @@ async def _persist_rating_changes(
                         scoreTime=func.now(),
                     )
                 )
-                await conn.execute(gps_update_sql)
+                result = await conn.execute(gps_update_sql)
+
+                if not result.rowcount:
+                    self._logger.warning("gps_update_sql resultset is empty for game_id %i", game_id)
+                    return
 
                 rating_type_id = self._rating_type_ids[rating_type]
 

diff --git a/tests/unit_tests/test_rating_service.py b/tests/unit_tests/test_rating_service.py
@@ -343,3 +343,18 @@ async def test_game_rating_error_handled(rating_service, game_info, bad_game_inf
     service._logger.warning.assert_called()
     # second game: results have been saved.
     service._persist_rating_changes.assert_called_once()
+
+
+async def test_game_update_empty_resultset(rating_service):
+    service = rating_service
+    game_id = 2
+    player_id = 1
+    rating_type = RatingType.GLOBAL
+    old_ratings = {player_id: Rating(1000, 500)}
+    after_mean = 1234
+    new_ratings = {player_id: Rating(after_mean, 400)}
+    outcomes = {player_id: GameOutcome.VICTORY}
+
+    await service._persist_rating_changes(
+        game_id, rating_type, old_ratings, new_ratings, outcomes
+    )