Reduce the lifetime of water trails#6088
Closed
Garanas wants to merge 6 commits intodeploy/fafdevelopfrom
Closed
Conversation
Now also affects torpedo defences, SAMs and TMDs. Bug: HARMS still always points south. Previously t2 arty pointed only north or south towards closest enemy or center. Now all t2+ static arty points at center of map but limited to 90 degree steps in order to not affect pathing/terrain.
Co-authored-by: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Co-authored-by: lL1l1 <82986251+lL1l1@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This reduces the life time of water trails to a similar value to what we have for footprints and tread marks. When you zoom out and back in all emitters are recomputed. The water trails are surprisingly complex (multiple emitters per unit that last 10 to 15 seconds on average) and are therefore a prime target for a frame time spike.
Testing done on the proposed changes
Spawn in naval units and observe the trail.
Additional context
I'd also like to review the other water trail effects.
Checklist