Optimize Zthuee projectiles (amongst other projectile things)#3718
Merged
Garanas merged 7 commits intoFAForever:deploy/fafdevelopfrom Mar 25, 2022
Merged
Conversation
Member
Author
|
Ran tests on several games, all appears to be good. |
This was referenced Mar 25, 2022
Garanas
added a commit
that referenced
this pull request
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our benchmark is 400 Zthuee firing at once on the map White Fire. The map has no civilians. All functionality of the original projectile is still there, just faster. A base line is the same scenario, but without the Zthuee firing.
On the FAF branch:

12 - 14 mswith a base line of3 msThis pull request:

9 - 12 mswith a base line of3 msThis pull request, without decals:

9 - 10.5 mswith a base line of3 msIf we'd reduce the base lines:
9 - 11 msfor firing6 - 9 msfor firing6 - 7.5 mswhen firingTherefore we can safely assume that there's at least a 20% performance improvement. Some of these changes apply to all projectiles.