fix: check if unix socket is in use #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if two instances of process-compose are started with the same unix socket, the first instance is orphaned without any way to shut it down: ``` > process-compose up -u /tmp/sock --tui=false >/dev/null 2>&1 & [1] 52138 > process-compose up -u /tmp/sock --tui=false >/dev/null 2>&1 & [2] 52217 > process-compose down -u /tmp/sock [2] + done process-compose up -u /tmp/sock --tui=false > /dev/null 2>&1 > process-compose down -u /tmp/sock 24-08-07 11:59:19.436 FTL failed to stop project error="Post \"http://unix/project/stop/\": dial unix /tmp/sock: connect: no such file or directory" > pgrep process-compose 52138 ``` Instead of unconditionally removing an existing unix socket, error if it is already in use.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if two instances of process-compose are started with the same unix socket, the first instance is orphaned without any way to shut it down:
Instead of unconditionally removing an existing unix socket, error if it is already in use.