Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add subtitle media sequence data to insertSlate fn #307

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

Nfrederiksen
Copy link
Collaborator

@Nfrederiksen Nfrederiksen commented Dec 8, 2023

PR resolves #306,

PR has been tested on CE using the internal Chaos Monkey feature, and is verified to now behave as expected.

@Nfrederiksen Nfrederiksen marked this pull request as ready for review December 8, 2023 13:29
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nfrederiksen Nfrederiksen merged commit fcffe9e into master Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inserting Slate Does Not Step Subtitle Media Sequence Number Correctly
2 participants