Skip to content

Feature/send summary as email #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: development
Choose a base branch
from

Conversation

xurxodev
Copy link
Contributor

@xurxodev xurxodev commented Mar 6, 2025

📌 References

📝 Implementation

  • Add options button to show menu if exists error
  • Create Share Sync Dialog
  • Send email if email type is selected
  • Send message conversation if message is selected
  • Create email validation component
  • Create user, userGroup autocomplete component
  • Show error if you try send invalid comunication

To send emails is necessary to configure an smtp server in dhis2. I've used gmail account using app password to work

📹 Screenshots/Screen capture

Screen.Recording.2025-03-27.at.10.38.42.mov
Screenshot 2025-03-10 at 15 21 08 Screenshot 2025-03-10 at 15 21 28

With privacy policy check

Screenshot 2025-06-20 at 07 35 21

🔥 Is there anything the reviewer should know to test it?

Currently, there is a bug in 2.41 failing to access to external file using incognito window
https://dhis2.atlassian.net/browse/DHIS2-19544

📑 Others

  • Any change in the GUI library? If so, what branch/PR?

  • Any change in the D2 Api? If so, what branch/PR?

@xurxodev xurxodev marked this pull request as ready for review March 27, 2025 10:46
@xurxodev xurxodev changed the base branch from feature/remove_invalid_include_exclude_on_save to development April 16, 2025 04:32
@ifoche
Copy link
Member

ifoche commented Apr 16, 2025

…ummary_as_email

# Conflicts:
#	i18n/en.pot
#	i18n/es.po
#	i18n/fr.po
#	i18n/pt.po
#	src/data/common/utils/futures.ts
#	src/presentation/CompositionRoot.ts
Copy link

bundlemon bot commented Apr 16, 2025

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
1.94MB (+5.05KB +0.26%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@adrianq
Copy link
Member

adrianq commented Jun 18, 2025

@xurxodev to add a "disclaimer" checkbox letting the user know that some data will be shared. Message can be extracted from the feedback tool

@xurxodev
Copy link
Contributor Author

@adrianq ready

xurxodev added 3 commits June 23, 2025 13:29
…ummary_as_email

# Conflicts:
#	i18n/en.pot
#	src/presentation/CompositionRoot.ts
- To send email update it to public and external access
- To send message update it to access for user or user group recipients only
…ummary_as_email

# Conflicts:
# i18n/en.pot
# src/presentation/CompositionRoot.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants