fix: resolve ParameterReference in MERGE property matching#2
Merged
ExtReMLapin merged 1 commit intofixissue3476from Feb 18, 2026
Merged
Conversation
When a MERGE query used parameter references (e.g., $username) in node properties, the ParameterReference objects were not resolved before property matching. This caused MERGE to always create a new node instead of finding the existing one, mirroring the bug that was already fixed in MatchNodeStep.matchesProperties(). The fix adds ParameterReference resolution in MergeStep.evaluateProperties(), which is called before matchesProperties() for both node and edge patterns. Regression tests added to OpenCypherMergeTest: - mergeFindsNodeWithParameterReference: verifies no duplicate is created - mergeCreatesNodeWithParameterReference: verifies creation still works https://claude.ai/code/session_012HJWpf6hyoiJSrFo2Wyim1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a MERGE query used parameter references (e.g., $username) in node properties, the ParameterReference objects were not resolved before property matching. This caused MERGE to always create a new node instead of finding the existing one, mirroring the bug that was already fixed in MatchNodeStep.matchesProperties().
The fix adds ParameterReference resolution in MergeStep.evaluateProperties(), which is called before matchesProperties() for both node and edge patterns.
Regression tests added to OpenCypherMergeTest:
https://claude.ai/code/session_012HJWpf6hyoiJSrFo2Wyim1
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?
Checklist
mvn clean packagecommand