Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

have IPCError inherit DiscordException #33

Merged
merged 1 commit into from
Apr 29, 2021
Merged

have IPCError inherit DiscordException #33

merged 1 commit into from
Apr 29, 2021

Conversation

ShineyDev
Copy link
Member

Description

This PR changes the base for IPCError to DiscordException, following extension guarantees.

Checklist

  • This PR has been tested.

@ShineyDev ShineyDev added T:enhancement This requests or implements an enhancement. P:low This can be deferred. labels Apr 21, 2021
@ShineyDev ShineyDev requested a review from a team as a code owner April 21, 2021 13:57
lgaan
lgaan approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@lgaan lgaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@lgaan lgaan merged commit 706cabc into Ext-Creators:main Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgaan lgaan lgaan approved these changes

Assignees

@lgaan lgaan

Labels
P:low This can be deferred. T:enhancement This requests or implements an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShineyDev @lgaan