Skip to content

fix getting setting - #20

Merged
ExplodingCabbage merged 1 commit into
ExplodingCabbage:masterfrom
floydwch:fix-getting-setting
Nov 26, 2016
Merged

ExplodingCabbage merged 1 commit into
ExplodingCabbage:masterfrom
floydwch:fix-getting-setting

Conversation

@floydwch

@floydwch floydwch commented May 1, 2016

Copy link
Copy Markdown
Contributor

The dict get would get NoneType thus cause #19 .

@Kristinita

Copy link
Copy Markdown

@ExplodingCabbage, why you not review this pull-request? It's fixed problems on my Windows. Thanks.

@ExplodingCabbage

Copy link
Copy Markdown
Owner

I'm not sure how people are hitting the case that this would fix, since as far as I can see this would only ever come into play if they explicitly had nulls set in their preferences. But since that case at least is possible, I guess I'll merge this.

@ExplodingCabbage
ExplodingCabbage merged commit 68ce9e2 into ExplodingCabbage:master Nov 26, 2016
@ExplodingCabbage

Copy link
Copy Markdown
Owner

Sorry for taking a while to get round to this, by the way. I completely forgot it was open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants