Skip to content

Conversation

@Expl0dingBanana
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds room tracking functionality to the Afero bridge by introducing an AferoRoom type and methods to manage room-device relationships. The implementation allows tracking which devices belong to which rooms based on API data.

  • Added AferoRoom TypedDict to represent room data structure
  • Implemented room tracking with lookup tables for device-to-room mapping
  • Integrated room updates into the polling process

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/aioafero/types.py Defines the new AferoRoom TypedDict structure
src/aioafero/init.py Exports AferoRoom in the public API
src/aioafero/v1/init.py Implements room tracking logic with update_rooms and get_room_for_device methods
src/aioafero/v1/controllers/event.py Integrates room updates into the polling process
tests/v1/test___init__.py Adds comprehensive tests for room functionality
tests/v1/data/raw_hs_data.json Adds test data for room without ID scenario

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bfcbafb) to head (ec2aeb5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3181      3203   +22     
  Branches       495       500    +5     
=========================================
+ Hits          3181      3203   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants