Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on global threejs #19

Closed
wants to merge 1 commit into from

Conversation

wolfmanfx
Copy link

No description provided.

@mattdesl mattdesl closed this Jul 11, 2017
@mattdesl
Copy link
Contributor

Thanks but this is a design decision, see here:
#9 (comment)

As soon as you require ThreeJS the bundle size will go way up. Not everybody is using ThreeJS via npm and the chances of using the same version is pretty low (it changes so frequently). This is why it's a peer dependency instead of a regular dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants