Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add verticalScrollbarPosition prop to ScrollView #33

Merged
merged 1 commit into from
Nov 21, 2022
Merged

feat: add verticalScrollbarPosition prop to ScrollView #33

merged 1 commit into from
Nov 21, 2022

Conversation

hannojg
Copy link

@hannojg hannojg commented Nov 17, 2022 •
edited by mountiny
Loading

Summary

This is a temporary addition to help circumvent a bug on android. Long term we want to fix the root cause of the problem.

Changelog

[Android] [Added] - add verticalScrollbarPosition prop (can be left or right)

Test Plan

@hannojg
add verticalScrollbarPosition prop to ScrollView
95d3b1f 
This is a temporary addition to help circumvent a bug on android.
Long term we want to fix the root cause of the problem.

- RN issue: facebook#35350
- Expensify issue: Expensify/App#11321 (comment)
@hannojg hannojg mentioned this pull request Nov 17, 2022
Merged
97 tasks
mountiny
mountiny approved these changes Nov 21, 2022
View reviewed changes
Copy link

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, we would need to do a release of our branch. @roryabraham is that something you could help with?

Beamanator
Beamanator approved these changes Nov 21, 2022
View reviewed changes
Copy link

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me!

@Beamanator Beamanator merged commit 99c26e2 into Expensify:main Nov 21, 2022
@melvin-bot melvin-bot bot added the Emergency label Nov 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

@Beamanator looks like this was merged without the danger test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link

Tests were passing.

@AndrewGable
Copy link

I'm going to publish this under expensify/react-native@0.70.4-alpha.2 Which will continue to use react native 0.70.4, but just with this commit added on.

@roryabraham roryabraham mentioned this pull request Feb 11, 2023
Merged
@fabioh8010 fabioh8010 mentioned this pull request Jul 5, 2023
Merged
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@Beamanator Beamanator Beamanator approved these changes

@roryabraham roryabraham Awaiting requested review from roryabraham

Assignees

@hannojg hannojg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannojg @mountiny @AndrewGable @Beamanator