Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: small images for scaling problem #8761

Merged
merged 16 commits into from
Jul 11, 2022
Merged

fixed: small images for scaling problem #8761

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
25fa661
small images for scaling problem fixed
metehanozyurt Apr 24, 2022
d2715fc
Unnecessary lines deleted
metehanozyurt Apr 25, 2022
184e4ca
Unnecessary conditions and callbacks deleted
metehanozyurt Apr 26, 2022
71be3ee
in setImageRegion function imageHeight condition added
metehanozyurt Apr 30, 2022
2bc6fa6
reverted change
metehanozyurt May 13, 2022
f4c50c9
Merge branch 'main' of https://github.com/Expensify/App into issue-8471
metehanozyurt May 22, 2022
fe81aaa
removed thumbnail from native code when loading, condition has been a…
metehanozyurt May 22, 2022
b05db83
setScale method added.
metehanozyurt May 24, 2022
aee1d1e
Removed unnecessary variable assignments.
metehanozyurt May 24, 2022
5aa5749
zoomScale calculation on mWeb added and when loading images doesnt sh…
metehanozyurt May 31, 2022
bf03160
typo fixed
metehanozyurt May 31, 2022
ee96405
comment changed
metehanozyurt Jun 4, 2022
eb3d169
comments became more understandable.
metehanozyurt Jun 17, 2022
25ab7dc
Comments moved before prop.
metehanozyurt Jun 20, 2022
0dc63b0
Merge branch 'main' of https://github.com/Expensify/App into issue-8471
metehanozyurt Jul 6, 2022
43876b5
heights checked in setScale function
metehanozyurt Jul 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
in setImageRegion function imageHeight condition added
  • Loading branch information
@metehanozyurt
metehanozyurt committed Apr 30, 2022
commit 71be3ee3b2f6a4c311d13b1bb66a9197f1eed648
5 changes: 5 additions & 0 deletions src/components/ImageView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ class ImageView extends PureComponent {
const containerHeight = this.state.containerHeight;
const containerWidth = this.state.containerWidth;

// return if image not loaded yet
if (imageHeight <= 0) {
return;
}

let imgLeft = (this.props.windowWidth - width) / 2;
let imgRight = ((this.props.windowWidth - width) / 2) + width;
let imgTop = (this.props.windowHeight - height) / 2;
Expand Down