-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Create collect-upgrade.md hidden help page #76065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Parent GH Expensify/Expensify#538526 Release 4 Expensify/Expensify#563179 > Create a hidden help site page (can only be accessed with a link) so AZ can answer questions correctly about this change (without broadcasting it publicly)
|
All contributors have signed the CLA ✍️ ✅ |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
A preview of your ExpensifyHelp changes have been deployed to https://cdb6d93d.helpdot.pages.dev ⚡️ Updated articles: |
Co-authored-by: Sheena Trepanier <sheena@expensify.com>
strepanier03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion, what do you think?
|
recheck |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
strepanier03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new preview looks good with the small change to the FAQ.
|
I have read the CLA Document and I hereby sign the CLA |
strepanier03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good, will merge after checking the preview.
|
🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.2.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀
|
Explanation of Change
Fixed Issues
Parent GH https://github.com/Expensify/Expensify/issues/538526
Release 4 https://github.com/Expensify/Expensify/issues/563179
Tests
N/A
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.N/A
Screenshots/Videosundefined