-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add standardize the pay button help article image #75797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Removed product and design reviews as this is just adding a HelpDot image and the design team made this image for me. |
|
@dominictb please approve without reviewing to go to internal reviewer |
|
A preview of your ExpensifyHelp changes have been deployed to https://a7fbf76a.helpdot.pages.dev ⚡️ |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Approved. But just wonder which article would this picture be put into? |
|
🎯 @dominictb, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #75851. |
Thanks! It's going in this article. I'll add it once it's in the repo in a separate PR alongside some article changes. |
|
All yours @inimaga |
|
@joekaufmanexpensify is this no QA? |
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.2.64-0 🚀
|
|
@IuliiaHerets yep, no QA. I checked it off 👍 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀
|
Explanation of Change
Add standardize the pay button help article image
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/453274
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.