Skip to content

Revert "Merge pull request #74356 from callstack-internal/VickyStash/… #75356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
puneetlath merged 1 commit into from
Nov 17, 2025
Merged

Revert "Merge pull request #74356 from callstack-internal/VickyStash/… #75356

puneetlath merged 1 commit into from
Nov 17, 2025

Conversation

@puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Nov 17, 2025 •
edited
Loading

Reverts #74356

Fix for: #75295

@puneetlath
Revert "Merge pull request #74356 from callstack-internal/VickyStash/…
c35c620 
…refactor/73380-support-domain-workspace-cards-same-name"

This reverts commit f62e324, reversing
changes made to 8bf8f0a.
@puneetlath puneetlath self-assigned this Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 85.71% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/hooks/useCardsList.tsx 100.00% <100.00%> (ø)
src/hooks/useIsAllowedToIssueCompanyCard.ts 100.00% <100.00%> (ø)
src/hooks/useUpdateFeedBrokenConnection.ts 0.00% <ø> (ø)
...nyCards/WorkspaceCompanyCardsErrorConfirmation.tsx 0.00% <ø> (ø)
...space/companyCards/addNew/CardInstructionsStep.tsx 0.00% <ø> (ø)
...kspace/companyCards/addNew/PlaidConnectionStep.tsx 2.63% <ø> (ø)
...ace/companyCards/assignCard/AssignCardFeedPage.tsx 58.82% <ø> (ø)
...workspace/companyCards/assignCard/AssigneeStep.tsx 52.17% <100.00%> (ø)
... and 22 more
... and 7 files with indirect coverage changes

@puneetlath puneetlath marked this pull request as ready for review November 17, 2025 21:58
@puneetlath puneetlath requested review from a team as code owners November 17, 2025 21:58
@melvin-bot melvin-bot bot requested review from JmillsExpensify and chiragsalian and removed request for a team November 17, 2025 21:58
@melvin-bot
Copy link

melvin-bot bot commented Nov 17, 2025

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@puneetlath puneetlath merged commit 06aea8a into main Nov 17, 2025
35 of 45 checks passed
@puneetlath puneetlath deleted the revert-74356 branch November 17, 2025 22:21
@melvin-bot melvin-bot bot added the Emergency label Nov 17, 2025
@melvin-bot
Copy link

melvin-bot bot commented Nov 17, 2025

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor Author

puneetlath commented Nov 17, 2025

Went ahead and merged since it's a revert of a deploy blocker causing PR.

@os-botify os-botify bot mentioned this pull request Nov 17, 2025
Merged
52 tasks
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 17, 2025
puneetlath added a commit that referenced this pull request Nov 17, 2025
@puneetlath
Merge pull request #75356 from Expensify/revert-74356
80df068 
Revert "Merge pull request #74356 from callstack-internal/VickyStash/…

(cherry picked from commit 06aea8a)

(cherry-picked to staging by puneetlath)
carlosmiceli added a commit that referenced this pull request Nov 17, 2025
@carlosmiceli
Merge pull request #75359 from Expensify/cherry-pick-staging-75356-19…
83d29f5 
…446632550-1

🍒 Cherry pick PR #75356 to staging 🍒
@OSBotify OSBotify mentioned this pull request Nov 18, 2025
Closed
58 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Nov 18, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.60-0 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 18, 2025

@puneetlath I believe we can check it off, right?

@amyevans
Copy link
Contributor

amyevans commented Nov 18, 2025

@IuliiaHerets yep you can check it off, thanks!

@OSBotify
Copy link
Contributor

OSBotify commented Nov 18, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.60-0 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

VickyStash added a commit to callstack-internal/Expensify-App that referenced this pull request Nov 18, 2025
@VickyStash
Revert "Merge pull request Expensify#75356 from Expensify/revert-74356"
a60674a 
This reverts commit 06aea8a, reversing
changes made to e3cfcaf.
@OSBotify
Copy link
Contributor

OSBotify commented Nov 18, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.60-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 19, 2025

🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Nov 19, 2025

🚀 Deployed to production by https://github.com/grgia in version: 9.2.60-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify OSBotify mentioned this pull request Nov 26, 2025
Closed
70 tasks
@IuliiaHerets
Copy link

IuliiaHerets commented Nov 26, 2025

@puneetlath do we need to QA this?

@OSBotify
Copy link
Contributor

OSBotify commented Nov 26, 2025

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.64-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 27, 2025

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.64-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amyevans amyevans amyevans approved these changes

@chiragsalian chiragsalian chiragsalian approved these changes

@grgia grgia grgia approved these changes

@JmillsExpensify JmillsExpensify Awaiting requested review from JmillsExpensify

Assignees

@puneetlath puneetlath

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@puneetlath @OSBotify @IuliiaHerets @amyevans @chiragsalian @grgia