-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[NO QA] feat: allow running AI code reviews with Claude from forks #71300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] feat: allow running AI code reviews with Claude from forks #71300
Conversation
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Failing on forks after merging, my advice is to revert this for now (tldr it's not that simple to integrate and cannot be quickly fixed give all security concerns in play). |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.19-0 🚀
|
|
@adhorodyski @mountiny Anything for the QA to check? |
|
I'm not going to block app deploy on this, but please add internalQA or |
|
This was reverted so nothing to do here #71316 |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀
|
@mountiny @AndrewGable @madmax330
Explanation of Change
We initially implemented code reviews with Claude for internal PRs, with the goal to enable them for PRs coming from forks.
This PR takes advantage of the new
pull_request_targettrigger support implemented in anthropics/claude-code-action#579.Fixed Issues
$
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1758722773553319?thread_ts=1758570512.283659&cid=C05LX9D6E07
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop