-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: track-merchant field is shown instead of distance and rate field #54273
fix: track-merchant field is shown instead of distance and rate field #54273
Whoa there!
You have triggered an abuse detection mechanism.
Please wait a few minutes before you try again;
in some cases this may take up to an hour.
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Lines 2276 to 2278 in fae8b36
Lines 4226 to 4228 in fae8b36
I noticed we have used this condition elsewhere. I'm checking if it leads to a similar issue. |
Checked, it doesn't have similar issues. |
@linhvovan29546 Is it possible to add a test for the same? |
I tested some possible cases, and i don't see issue similar, maybe I missed something |
I've noticed 2 other bugs similar to this one (this is not related to the change in this PR, but I think it also exists in production), which seem to stem from the BE after track expenses for a user who is not in a chat:
Screen.Recording.2024-12-19.at.10.55.22.PM.2.mp4 |
Do you mean automated test? |
Hi @mananjadhav Please help review when you have a chance. I've also left a comment here |
Going to review this by tomorrow. |
Just got back to reviewing tis and asked a question here |
Replied |
@linhvovan29546 Can you please sync with the latest main and resolve conflicts? |
@linhvovan29546 For the test steps it is okay to copy from the reproduction steps, but I think we should highlight the expected behavior in this scenario. Also if there's any precondition for the account, example if it should be a new account, etc. |
14492c1
to
e5108a1
Compare
Sorry for this mistake, I will reopen it again. |
@mananjadhav Resolved conflicts.
It doesn't require any precondition account. I just updated some comments in the test. Could you please review it again? Thank you. |
I don't see the expected behavior in the tests. Can you please add that?
|
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-distance-request-field.movAndroid: mWeb Chromemweb-chrome-distance-requerst-field.moviOS: Nativeios-distance-request-field.moviOS: mWeb Safarimweb-safari-distance-request-field.movMacOS: Chrome / Safariweb-distance-request-field.movMacOS: Desktopdesktop-distance-request-field.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.81-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀
|
Explanation of Change
Fixed Issues
$ #53712
PROPOSAL: #53712 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
OneCameraFinalVideo.mp4
Android: mWeb Chrome
Android-mweb.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-18.at.10.16.00.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-18.at.10.11.36.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-12-18.at.9.07.45.AM.mp4
MacOS: Desktop
Screen.Recording.2024-12-18.at.10.04.19.AM.mp4