-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Bump react-native-live-markdown to 0.1.209 #54265
[NoQA] Bump react-native-live-markdown to 0.1.209 #54265
Conversation
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ZhenjaHorbach let's prioritize reviewing this one since it solves internal native builds |
No problem ! |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb ChromeScreenrecorder-2024-12-18-17-00-46-473.mp4iOS: mWeb Safariios-web.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Thanks Andrew for merging this! |
…ive-markdown-0.1.209 [NoQA] Bump react-native-live-markdown to 0.1.209 (cherry picked from commit 3d7ef92) (CP triggered by luacmartins)
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.77-2 🚀
|
3 similar comments
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.77-2 🚀
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.77-2 🚀
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.77-2 🚀
|
As for Android HybridApp deploy failure, not sure if this is related but @jnowakow had a problem with missing |
Yea, jitpack is down https://status.jitpack.io/ |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀
|
Explanation of Change
This PR bumps
@expensify/react-native-live-markdown
from0.1.207
to0.1.209
in order to include PR Expensify/react-native-live-markdown#589 that fixes #54256.Fixed Issues
$ #54256
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop