-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SMS Delivery Failure sign in flow #54150
Conversation
I started a discussion on Slack to confirm the translation |
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@nyomanjyotisa At the Testcase 3, after steps 6, I assume that we should continue logging in as normal right? In this case, If I entered another email and enter, I got the validate page instead of entering magic code: Screen.Recording.2024-12-17.at.14.06.42.movUpdate: |
What's the status here? Can we try to make one last sprint and wrap this one up? |
The issue arises because the |
Ah, I see, that's going to be ready when we merge the BE. Does this mean we're good to go here @hungvu193 ? I-ll do the QA with the BE once this merged. |
Yes. I'll complete the checklist in couple of hours |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid.1.movAndroid: mWeb ChromemChrome1.moviOS: Nativeios1.moviOS: mWeb SafariSafari.1.movMacOS: Chrome / SafariChrome1.movChrome2.movMacOS: DesktopChrome1.movChrome2.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@nyomanjyotisa I made a mistake with the deployment order here, so we had to revert this PR. Could you raise a new PR with the same changes? I'll put it on hold until the BE is deployed, thanks and sorry for the trouble. 🙏 |
No worries at all, I've already raised the new PR with the same changes @carlosmiceli |
Explanation of Change
Fixed Issues
$ #53980
PROPOSAL: #53980 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Test 1 (Simulate SMS Failure):
Onyx.merge("account", {smsDeliveryFailureStatus: {}});
in the console.smsDeliveryFailurePage
is displayed correctly.Test 2 (Simulate Validate Fail):
Onyx.merge("account", {smsDeliveryFailureStatus: {isReset: true, hasSMSDeliveryFailure: true, message: "Please wait 23 hours and 37 minutes before trying again."}});
on the consoleTest 3 (Simulate Validate Success):
Onyx.merge("account", {smsDeliveryFailureStatus: {isReset: true, hasSMSDeliveryFailure: false}});
on the consoleBeginSignIn
API calledOnyx.merge("account", {smsDeliveryFailureStatus: null});
on the consolePR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.Chrome.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-mWeb.Safari.mp4
MacOS: Chrome / Safari
MacOS-Chrome.mp4
MacOS: Desktop
MacOS-Desktop.mp4