fix: Deleted room is displayed in the 'Assign task' #51625

nkdengineer · 2024-10-29T03:52:02Z

Details

Fixed Issues

$ #50418
PROPOSAL: #50418 (comment)

Tests

Create a workspace
Add some messages in the #admin channel
Click on FAB
Click on create task
Search for the #admin room of the created workspace
Create the task
Verify the task is created in the #admin room
Delete the workspace
Click on FAB on the LHN
Click on assign task
Verify that: After deleting a workspace, it's rooms are not displayed in the account

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-10-29T10:50:00Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-10-31T11:24:54Z

@nkdengineer The subtitle isn't showing up even when the workspace is still available:

nkdengineer · 2024-11-01T08:08:25Z

@Ollyws i fixed this bug

Ollyws · 2024-11-05T15:07:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

tgolen

Can you please add a unit test to ensure that the bug doesn't come back?

tgolen · 2024-11-06T16:10:15Z

Bump for unit tests, please.

nkdengineer · 2024-11-08T03:28:48Z

working on this PR

nkdengineer · 2024-11-08T07:39:34Z

@tgolen, I'm a bit confused about how we can add a unit test for this case.

tgolen · 2024-11-08T15:56:42Z

What's your confusion and how can I help resolve it?

nkdengineer · 2024-11-08T16:05:03Z

@tgolen My confusion is what test we can add in this case and where we can add this because it's not a util function and it's just a variable in the component.

tgolen · 2024-11-08T16:30:04Z

You should be able to write unit tests for components. I think the test should:

Put some "setup" data into Onyx (eg. the "deleted room")
Render the FAB component
Verify that it doesn't show the deleted room

nkdengineer · 2024-11-11T07:57:17Z

@tgolen let me try

nkdengineer · 2024-11-11T15:55:04Z

@tgolen I think in this case we can create a util function to get quickActionAvatars, quickActionTitle, hideQABSubtitle then we can add a unit test for this util. what do you think?

tgolen · 2024-11-11T15:56:16Z

Sounds like that would work as well, yeah 👍 Good thinking

nkdengineer · 2024-11-12T10:04:41Z

@Ollyws i added, please check again

tgolen · 2024-11-12T17:45:34Z

tests/unit/ReportUtilsTest.ts

@@ -975,6 +975,22 @@ describe('ReportUtils', () => {
        });
    });

+    describe('getQuickActionDetails', () => {


Thanks for adding this test!

Can you please follow this format to add a little bit of context and documentation to the test?

@tgolen i updated

nkdengineer added 3 commits October 29, 2024 10:51

fix: Deleted room is displayed in the 'Assign task'

0abb380

Merge branch 'main' into fix/50418

e5c21aa

fix eslint

5889c08

nkdengineer marked this pull request as ready for review October 29, 2024 10:49

nkdengineer requested a review from a team as a code owner October 29, 2024 10:49

melvin-bot bot requested review from Ollyws and removed request for a team October 29, 2024 10:49

Merge branch 'main' into fix/50418

6b83b80

nkdengineer added 2 commits November 1, 2024 15:02

Merge branch 'main' into fix/50418

8c5dedd

fix show QAB subtitle

83a70f9

resolve conflict

0c76e41

Ollyws approved these changes Nov 5, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen November 5, 2024 15:07

tgolen requested changes Nov 5, 2024

View reviewed changes

nkdengineer added 2 commits November 7, 2024 16:18

resolve conflict

f4b5456

fix lint

69f1806

fix lint

4ea4fcd

Merge branch 'main' into fix/50418

5dbe5e5

nkdengineer added 2 commits November 12, 2024 16:33

fix: add test for QAB

bbbcce9

resolve conflict

5447d04

tgolen requested changes Nov 12, 2024

View reviewed changes

nkdengineer added 5 commits November 14, 2024 15:19

merge main

f13f4e3

add comment context

d3c1b99

fix test

784ec89

fix lint

76ce7c8

Merge branch 'main' into fix/50418

d9a6af7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Deleted room is displayed in the 'Assign task' #51625

fix: Deleted room is displayed in the 'Assign task' #51625

nkdengineer commented Oct 29, 2024 •

edited

Loading

melvin-bot bot commented Oct 29, 2024

Ollyws commented Oct 31, 2024 •

edited

Loading

nkdengineer commented Nov 1, 2024

Ollyws commented Nov 5, 2024

Ollyws left a comment

tgolen left a comment

tgolen commented Nov 6, 2024

nkdengineer commented Nov 8, 2024

nkdengineer commented Nov 8, 2024

tgolen commented Nov 8, 2024

nkdengineer commented Nov 8, 2024

tgolen commented Nov 8, 2024

nkdengineer commented Nov 11, 2024

nkdengineer commented Nov 11, 2024

tgolen commented Nov 11, 2024

nkdengineer commented Nov 12, 2024

tgolen Nov 12, 2024

nkdengineer Nov 15, 2024

fix: Deleted room is displayed in the 'Assign task' #51625

Are you sure you want to change the base?

fix: Deleted room is displayed in the 'Assign task' #51625

Conversation

nkdengineer commented Oct 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 29, 2024

Ollyws commented Oct 31, 2024 • edited Loading

nkdengineer commented Nov 1, 2024

Ollyws commented Nov 5, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

tgolen left a comment

Choose a reason for hiding this comment

tgolen commented Nov 6, 2024

nkdengineer commented Nov 8, 2024

nkdengineer commented Nov 8, 2024

tgolen commented Nov 8, 2024

nkdengineer commented Nov 8, 2024

tgolen commented Nov 8, 2024

nkdengineer commented Nov 11, 2024

nkdengineer commented Nov 11, 2024

tgolen commented Nov 11, 2024

nkdengineer commented Nov 12, 2024

tgolen Nov 12, 2024

Choose a reason for hiding this comment

nkdengineer Nov 15, 2024

Choose a reason for hiding this comment

nkdengineer commented Oct 29, 2024 •

edited

Loading

Ollyws commented Oct 31, 2024 •

edited

Loading