Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] [3rd Party Feeds] Update CARDASSIGNED report action text #51406

Merged
merged 3 commits into from
Oct 29, 2024
Merged

[No QA] [3rd Party Feeds] Update CARDASSIGNED report action text #51406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6de5097
Update CARDASSIGNED report action text
VickyStash Oct 24, 2024
7bf19a5
Lint fix
VickyStash Oct 24, 2024
8f55d82
Fix translation
VickyStash Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import type {
ApprovalWorkflowErrorParams,
ApprovedAmountParams,
AssignCardParams,
AssignedYouCardParams,
AssignedCardParams,
AssigneeParams,
AuthenticationErrorParams,
AutoPayApprovedReportsLimitErrorParams,
Expand Down Expand Up @@ -3140,7 +3140,7 @@ const translations = {
brokenConnectionErrorFirstPart: `Card feed connection is broken. Please `,
brokenConnectionErrorLink: 'log into your bank ',
brokenConnectionErrorSecondPart: 'so we can establish the connection again.',
assignedYouCard: ({link}: AssignedYouCardParams) => `assigned you a ${link}! Imported transactions will appear in this chat.`,
mountiny marked this conversation as resolved.
Show resolved Hide resolved
assignedCard: ({assignee, link}: AssignedCardParams) => `assigned ${assignee} a ${link}! Imported transactions will appear in this chat.`,
companyCard: 'company card',
chooseCardFeed: 'Choose card feed',
},
Expand Down
4 changes: 2 additions & 2 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type {
ApprovalWorkflowErrorParams,
ApprovedAmountParams,
AssignCardParams,
AssignedYouCardParams,
AssignedCardParams,
AssigneeParams,
AuthenticationErrorParams,
AutoPayApprovedReportsLimitErrorParams,
Expand Down Expand Up @@ -3180,7 +3180,7 @@ const translations = {
brokenConnectionErrorFirstPart: `La conexión de la fuente de tarjetas está rota. Por favor, `,
brokenConnectionErrorLink: 'inicia sesión en tu banco ',
brokenConnectionErrorSecondPart: 'para que podamos restablecer la conexión.',
assignedYouCard: ({link}: AssignedYouCardParams) => `te ha asignado una ${link}! Las transacciones importadas aparecerán en este chat.`,
assignedCard: ({assignee, link}: AssignedCardParams) => `ha asignado a ${assignee} una ${link}! Las transacciones importadas aparecerán en este chat.`,
companyCard: 'tarjeta de empresa',
chooseCardFeed: 'Elige feed de tarjetas',
},
Expand Down
5 changes: 3 additions & 2 deletions src/languages/params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,8 @@ type SpreadCategoriesParams = {
categories: number;
};

type AssignedYouCardParams = {
type AssignedCardParams = {
assignee: string;
link: string;
};

Expand Down Expand Up @@ -558,7 +559,7 @@ export type {
FeatureNameParams,
SpreadSheetColumnParams,
SpreadFieldNameParams,
AssignedYouCardParams,
AssignedCardParams,
SpreadCategoriesParams,
DelegateRoleParams,
DelegatorParams,
Expand Down
3 changes: 2 additions & 1 deletion src/libs/ReportActionsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,6 +1754,7 @@ function getCardIssuedMessage(reportAction: OnyxEntry<ReportAction>, shouldRende
reportAction,
CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED,
CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED_VIRTUAL,
CONST.REPORT.ACTIONS.TYPE.CARD_ASSIGNED,
CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS,
)
? getOriginalMessage(reportAction)
Expand Down Expand Up @@ -1790,7 +1791,7 @@ function getCardIssuedMessage(reportAction: OnyxEntry<ReportAction>, shouldRende
case CONST.REPORT.ACTIONS.TYPE.CARD_ISSUED_VIRTUAL:
return Localize.translateLocal('workspace.expensifyCard.issuedCardVirtual', {assignee, link: expensifyCardLink});
case CONST.REPORT.ACTIONS.TYPE.CARD_ASSIGNED:
return Localize.translateLocal('workspace.companyCards.assignedYouCard', {link: companyCardLink});
return Localize.translateLocal('workspace.companyCards.assignedCard', {assignee, link: companyCardLink});
case CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS:
return Localize.translateLocal(`workspace.expensifyCard.${shouldShowAddMissingDetailsMessage ? 'issuedCardNoShippingDetails' : 'addedShippingDetails'}`, {assignee});
default:
Expand Down
Loading