Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS Migration] Improve Form #35584

Merged
merged 54 commits into from
Feb 13, 2024
Merged

[TS Migration] Improve Form #35584

merged 54 commits into from
Feb 13, 2024

Commits on Feb 1, 2024

  1. Use more accurate type for ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT form

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4f109b2 View commit details
    Browse the repository at this point in the history

  2. Clean form onyx values

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5a9b7fa View commit details
    Browse the repository at this point in the history

  3. Move InputWrapperProps to InputWrapper file

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1865489 View commit details
    Browse the repository at this point in the history

  4. Add more generic types to FormWrapper

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ea73d4f View commit details
    Browse the repository at this point in the history

  5. Move RegisterInput to FormContext file

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8a06c0a View commit details
    Browse the repository at this point in the history

  6. Improve Form types, rename utility types

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ede25e5 View commit details
    Browse the repository at this point in the history

  7. Fix type errors in validation functions

    @blazejkustra
    blazejkustra committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    35356da View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c5e9982 View commit details
    Browse the repository at this point in the history

  2. Clean ONYXKEYS

    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    fbadba9 View commit details
    Browse the repository at this point in the history

  3. Remove OnyxFormKeyWithoutDraft, now OnyxFormKey and OnyxFormDraftKey … 

    …exist
    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6e2bf36 View commit details
    Browse the repository at this point in the history

  4. Use OnyxKey instead of OnyxKeys

    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e4caa67 View commit details
    Browse the repository at this point in the history

  5. Add ts-expect-error to all reimburesementAccount usage

    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    06ee35e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8b4f885 View commit details
    Browse the repository at this point in the history

  7. Fix eslint

    @blazejkustra
    blazejkustra committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8db9304 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Merge branch 'main' into ts/improve-form 

    udiff]
	external = difft
    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    488c935 View commit details
    Browse the repository at this point in the history

  2. Fix CloseAccountForm

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    94e6d41 View commit details
    Browse the repository at this point in the history

  3. Fix onyxkeys

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b894733 View commit details
    Browse the repository at this point in the history

  4. Add AssertTypesEqual utility type

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ffd0a26 View commit details
    Browse the repository at this point in the history

  5. Migrate input ids to constant object

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4488723 View commit details
    Browse the repository at this point in the history

  6. Add remaining inputs

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    87e4ea1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    16529f2 View commit details
    Browse the repository at this point in the history

  8. Move isFocused prop

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0a07743 View commit details
    Browse the repository at this point in the history

  9. Use INPUT_IDS in markdown as well

    @blazejkustra
    blazejkustra committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    30a91f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Simplify FormOnyxKeys type

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ede62bd View commit details
    Browse the repository at this point in the history

  2. Add custom error to AssertOnyxKeys

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    06394df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4708fae View commit details
    Browse the repository at this point in the history

  4. Fix package-lock

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ef0b5de View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    737b148 View commit details
    Browse the repository at this point in the history

  6. Move input ids to separate files

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    cd2e3e5 View commit details
    Browse the repository at this point in the history

  7. Make INPUT_IDS as default export

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    dcf3fb9 View commit details
    Browse the repository at this point in the history

  8. Fxi inputs imports

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bd4bb07 View commit details
    Browse the repository at this point in the history

  9. Add new form imports in ONYXKEYS

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    16c1089 View commit details
    Browse the repository at this point in the history

  10. Add new form imports in ONYXKEYS

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e9be3f4 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8b932c3 View commit details
    Browse the repository at this point in the history

  12. Fix typecheck failing

    @blazejkustra
    blazejkustra committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bec9ded View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b9130ee View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a931897 View commit details
    Browse the repository at this point in the history

  2. Move form types to src/types/form

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    dfb9ae9 View commit details
    Browse the repository at this point in the history

  3. Move BaseForm type to src/types/form

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b9b1b00 View commit details
    Browse the repository at this point in the history

  4. Fix imports

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d1baa7b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b0449c0 View commit details
    Browse the repository at this point in the history

  6. Adjust form docs

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f716077 View commit details
    Browse the repository at this point in the history

  7. Remove unused imports

    @blazejkustra
    blazejkustra committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8062eb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    72407eb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a10a841 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b138cc1 View commit details
    Browse the repository at this point in the history

  2. Fix typecheck and lint

    @blazejkustra
    blazejkustra committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    0d10ba1 View commit details
    Browse the repository at this point in the history

  3. Fix prettier

    @blazejkustra
    blazejkustra committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    575c163 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    dbd6335 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    611b6f3 View commit details
    Browse the repository at this point in the history

  2. Clean up typescript after merging bank refactor

    @blazejkustra
    blazejkustra committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a95392a View commit details
    Browse the repository at this point in the history

  3. Add remaining input

    @blazejkustra
    blazejkustra committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    fe4aace View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ts/improve-form

    @blazejkustra
    blazejkustra committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e11690d View commit details
    Browse the repository at this point in the history

  5. Fix prettier

    @blazejkustra
    blazejkustra committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    820e63e View commit details
    Browse the repository at this point in the history