fix IOU with category can be created when admin disable the same category #35540

dukenv0307 · 2024-02-01T05:06:35Z

Details

User can successfully create the IOU request when admin disable the same category

Fixed Issues

$ #35236
PROPOSAL: #35236 (comment)

Tests

Precondition:
User is an employee of Collect workspace on Old Dot which has categories set
Steps:

On collect workspace chat Employee starts manual request flow
On confirmation page select any category
Admin disable the same category on Old Dot
Verify that: category reset

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:
User is an employee of Collect workspace on Old Dot which has categories set
Steps:

On collect workspace chat Employee starts manual request flow
On confirmation page select any category
Admin disable the same category on Old Dot
Verify that: category reset

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…gory

melvin-bot · 2024-02-01T08:04:07Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-02-03T17:06:02Z

There are two solutions proposed here by @dukenv0307

The main proposal is to reset the category if the selected category is disabled by admin. However, this disappearance of category can be confusing so he gave an alternative proposal which will show an error at the category field (if it was disabled in the meantime by the admin) and on the confirm button asking the user to change the category.

Initially, I found the alternative proposal to be better here because it is clearer to the user but this being an edge case, I think the main proposal solution of resetting the category appears fine because it is simpler. This PR made these changes.

Shall we proceed with these changes?

@yuwenmemon

yuwenmemon · 2024-02-05T20:45:44Z

@c3024 let's proceed with the current fix and then once we've been using this feature for a bit we can revisit if we need an explicit error message.

c3024 · 2024-02-06T09:53:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

resetCategoryAndroid.mp4

Android: mWeb Chrome

resetCategoryAndroidChrome.mp4

iOS: Native

resetCategoryiOS.mp4

iOS: mWeb Safari

resetCategoryiOSSafari.mp4

MacOS: Chrome / Safari

resetCategoryChrome.mp4

MacOS: Desktop

resetCategoryDesktop.mp4

c3024

LGTM

yuwenmemon · 2024-02-06T18:53:45Z

@dukenv0307 you have a conflict :(

dukenv0307 · 2024-02-07T08:52:09Z

@yuwenmemon please check again

yuwenmemon · 2024-02-07T18:50:21Z

@dukenv0307 It also seems like this PR has been failing Performance Tests from the get-go - can you give a look at what's happening there?

Gonals · 2024-02-13T09:50:05Z

@dukenv0307 It also seems like this PR has been failing Performance Tests from the get-go - can you give a look at what's happening there?

@dukenv0307, bump on this!

dukenv0307 · 2024-02-13T17:58:55Z

Sorry for the late, I just merged main. Please check again

OSBotify · 2024-02-15T05:36:10Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

situchan · 2024-02-15T22:14:02Z

src/pages/iou/request/step/IOURequestStepConfirmation.js

+        if (!transaction.category) {
+            return;
+        }
+        if (policyCategories[transaction.category] && !policyCategories[transaction.category].enabled) {


App crashes on this line

Thanks. @situchan

Till the last commit of this PR

https://github.com/dukenv0307/App/blob/c93e6d05da9c42dc074cfc699dae75e9138bd47e/src/pages/iou/request/step/IOURequestStepConfirmation.js#L70

policyCategories has a default value of {}. Last main merge changed it to null. My review was not marked as stale. I could not check again after this commit before this PR got merged.

@dukenv0307 Could you raise a follow-up PR?

I'll raise a PR soon

As no response for 4 days, I raised fix - #36858
This is now 🔥 as app crashes on main user flow and reached production.
@c3024 can you please review?

@Gonals @yuwenmemon, the crash was raised while the PR was in staging. It would have been ideal to create a deploy blocker to avoid this crash in production, especially now when we want a stable App version for the earnings call.

@c3024 @situchan, please raise a bug in #expensify-bugs when similar situations happen to have someone create a deploy blocker to avoid crashes into production in the future.

Interesting though, that Applause didn't report the crash as happening in production 🤷‍♂️

yeah, you have to perform the reproduction steps real quick, so maybe it's not a big problem that it is in production, I think it's a rare case

OSBotify · 2024-02-19T23:34:18Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix IOU with category can be created when admin disable the same cate…

69e9292

…gory

dukenv0307 marked this pull request as ready for review February 1, 2024 08:04

dukenv0307 requested a review from a team as a code owner February 1, 2024 08:04

melvin-bot bot requested review from c3024 and removed request for a team February 1, 2024 08:04

dukenv0307 mentioned this pull request Feb 1, 2024

[HOLD for payment 2024-02-26] [$500] [MEDIUM] [Backwards Compatibility] Expense with category can be created when admin disable the same category #35236

Closed

6 tasks

Merge branch 'main' into fix/35236

b30aa57

yuwenmemon previously approved these changes Feb 5, 2024

View reviewed changes

c3024 approved these changes Feb 6, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals February 6, 2024 16:01

Merge branch 'main' into fix/35236

c93e6d0

dukenv0307 dismissed yuwenmemon’s stale review via c93e6d0 February 7, 2024 08:48

Merge branch 'main' into fix/35236

04d3ae9

Gonals approved these changes Feb 14, 2024

View reviewed changes

Gonals merged commit e6c321f into Expensify:main Feb 14, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 15, 2024

Deploy Checklist: New Expensify 2024-02-15 #36558

Closed

73 tasks

situchan reviewed Feb 15, 2024

View reviewed changes

ZhenjaHorbach mentioned this pull request Feb 20, 2024

[$500] Distance - App crashes when creating a distance request after creating a new workspace #36854

Closed

6 tasks

situchan mentioned this pull request Feb 20, 2024

[CP Staging] fix crash on money request confirmation page #36858

Merged

60 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix IOU with category can be created when admin disable the same category #35540

fix IOU with category can be created when admin disable the same category #35540

dukenv0307 commented Feb 1, 2024

melvin-bot bot commented Feb 1, 2024

c3024 commented Feb 3, 2024

yuwenmemon commented Feb 5, 2024

c3024 commented Feb 6, 2024 •

edited

Loading

c3024 left a comment

yuwenmemon commented Feb 6, 2024

dukenv0307 commented Feb 7, 2024

yuwenmemon commented Feb 7, 2024

Gonals commented Feb 13, 2024

dukenv0307 commented Feb 13, 2024

OSBotify commented Feb 15, 2024

situchan Feb 15, 2024

c3024 Feb 16, 2024 •

edited

Loading

dukenv0307 Feb 20, 2024

situchan Feb 20, 2024

cristipaval Feb 20, 2024

cristipaval Feb 20, 2024

cristipaval Feb 20, 2024

OSBotify commented Feb 19, 2024

fix IOU with category can be created when admin disable the same category #35540

fix IOU with category can be created when admin disable the same category #35540

Conversation

dukenv0307 commented Feb 1, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 1, 2024

c3024 commented Feb 3, 2024

yuwenmemon commented Feb 5, 2024

c3024 commented Feb 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

yuwenmemon commented Feb 6, 2024

dukenv0307 commented Feb 7, 2024

yuwenmemon commented Feb 7, 2024

Gonals commented Feb 13, 2024

dukenv0307 commented Feb 13, 2024

OSBotify commented Feb 15, 2024

situchan Feb 15, 2024

Choose a reason for hiding this comment

c3024 Feb 16, 2024 • edited Loading

Choose a reason for hiding this comment

dukenv0307 Feb 20, 2024

Choose a reason for hiding this comment

situchan Feb 20, 2024

Choose a reason for hiding this comment

cristipaval Feb 20, 2024

Choose a reason for hiding this comment

cristipaval Feb 20, 2024

Choose a reason for hiding this comment

cristipaval Feb 20, 2024

Choose a reason for hiding this comment

OSBotify commented Feb 19, 2024

c3024 commented Feb 6, 2024 •

edited

Loading

c3024 Feb 16, 2024 •

edited

Loading