`AutoscrollToTopThreshold` #34244

perunt · 2024-01-10T15:31:48Z

Details

Bring back autoscrollToTopThreshold after it was removed here https://github.com/Expensify/App/pull/32098/files#diff-b1c8c4fd8072edbd35c63a7cdd71b63ff1701a6f43529ea794f7720a86460df2L18

Fixed Issues

$ #34240
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Pre-requisites:

Login account A
Login account B on another device
DM chat between A and B should have enough messages history
On A, scroll down to the bottom to see latest message on DM chat with B
Case 1:

On A, Send any image or pdf attachment
Verify that image is fully seen
Case 2:

On B, Send message to A
Observe the chat page on A
Verify that the chat page scrolls down to the bottom to show the newly received message
Case 3: (especially iOS)

A requests money from B
B opens 1:1 DM with A
B taps Pay elsewhere on the IOU preview
On both A and B, verify that no empty space below IOU preview in 1:1 DM after paying elsewhere
Case 4: (especially iOS)

A requests money from B
Open IOU report on both accounts
Delete money request
On both A and B, verify that no empty space after IOU preview is removed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-01-10T16:22:14Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2024-01-10T17:15:12Z

I think we should probably bring this back, but it won't reliably fix #34240 – if you just leave some comments on the IOU report, then scroll to the top, then edit fields, it won't scroll back to the bottom if there's more than 128 pixels between you and the bottom. And I think that's expected – we wouldn't necessarily want to scroll you all the way back down to the bottom if you scrolled all the way up to edit a field – what if you want to edit another?

roryabraham · 2024-01-10T18:21:32Z

Discussing in https://expensify.slack.com/archives/C01GTK53T8Q/p1704907225899739 – this PR needs test steps to cover:

Uploading an attachment
Paying an IOU
Deleting an IOU

situchan · 2024-01-10T18:50:29Z

QA Steps

Pre-requisites:

Login account A
Login account B on another device
DM chat between A and B should have enough messages history
On A, scroll down to the bottom to see latest message on DM chat with B

Case 1:

On A, Send any image or pdf attachment
Verify that image is fully seen

Case 2:

On B, Send message to A
Observe the chat page on A
Verify that the chat page scrolls down to the bottom to show the newly received message

Case 3: (especially iOS)

A requests money from B
B opens 1:1 DM with A
B taps Pay elsewhere on the IOU preview
On both A and B, verify that no empty space below IOU preview in 1:1 DM after paying elsewhere

Case 4: (especially iOS)

A requests money from B
Open IOU report on both accounts
Delete money request
On both A and B, verify that no empty space after IOU preview is removed

situchan · 2024-01-10T19:23:11Z

Case 1, 2:

Screen.Recording.2024-01-11.at.1.19.39.AM.mov

situchan · 2024-01-10T19:27:03Z

Found unrelated bug while testing delete request:

Screen.Recording.2024-01-11.at.1.22.05.AM.mov

After deleting money request on A, IOU report preview doesn't disappear on B. Even not disappearing after refresh.
And when tap on it, IOU report auto closed and report preview becomes weird:

GH exists already?

situchan · 2024-01-10T19:31:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Case 1,2:

Screen.Recording.2024-01-11.at.1.19.39.AM.mov

Case 3,4:

Screen.Recording.2024-01-11.at.1.22.05.AM.mov

Screen.Recording.2024-01-11.at.1.28.29.AM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan

Deleting IOU seems broken on main.
Otherwise looks good!

situchan · 2024-01-10T19:46:51Z

This PR should fix the following deploy blockers:

[HOLD for payment 2024-01-22] [HOLD for payment 2024-01-18] IOU - App does not scroll down to show the latest message when editing expense request #34240
Chat - Chat Page does not scroll to the bottom when receiving new message #34279
Conversation - There is a delay between user's conversation #34269 (partial)

OSBotify · 2024-01-10T20:17:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2024-01-10T20:17:17Z

CPing this to staging

…hreshold `AutoscrollToTopThreshold` (cherry picked from commit 99e91c3)

OSBotify · 2024-01-10T20:42:13Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.24-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-11T08:53:21Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

autoscrollToTopThreshold

1c80e20

This was referenced Jan 10, 2024

HIGH: (Comment linking: step 2) [23220] WEB maintain visible content position #32098

Merged

[HOLD for payment 2024-01-22] [HOLD for payment 2024-01-18] IOU - App does not scroll down to show the latest message when editing expense request #34240

Closed

perunt marked this pull request as ready for review January 10, 2024 16:21

perunt requested a review from a team as a code owner January 10, 2024 16:21

melvin-bot bot requested review from AndrewGable and removed request for a team January 10, 2024 16:22

roryabraham mentioned this pull request Jan 10, 2024

Chat - Chat Page does not scroll to the bottom when receiving new message #34279

Closed

6 tasks

situchan approved these changes Jan 10, 2024

View reviewed changes

melvin-bot bot requested a review from roryabraham January 10, 2024 19:34

situchan mentioned this pull request Jan 10, 2024

Conversation - There is a delay between user's conversation #34269

Closed

6 tasks

roryabraham approved these changes Jan 10, 2024

View reviewed changes

roryabraham merged commit 99e91c3 into Expensify:main Jan 10, 2024
18 of 20 checks passed

OSBotify pushed a commit that referenced this pull request Jan 10, 2024

Merge pull request #34244 from margelo/perunt/return-autoscrollToTopT…

6b93aef

…hreshold `AutoscrollToTopThreshold` (cherry picked from commit 99e91c3)

github-actions bot mentioned this pull request Jan 10, 2024

Deploy Checklist: New Expensify 2024-01-10 #34203

Closed

54 tasks

situchan mentioned this pull request Jan 10, 2024

[$500] [HOLD for payment 2024-01-26] Request Money - User is redirected to chat then IOU report after deleting request offline #34263

Closed

6 tasks

thienlnam mentioned this pull request Jan 11, 2024

Request money - Scroll Issue When Navigating Back to the Amount After Selecting a User and Revisiting #34285

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`AutoscrollToTopThreshold` #34244

`AutoscrollToTopThreshold` #34244

perunt commented Jan 10, 2024 •

edited

Loading

melvin-bot bot commented Jan 10, 2024

roryabraham commented Jan 10, 2024

roryabraham commented Jan 10, 2024

situchan commented Jan 10, 2024

situchan commented Jan 10, 2024

situchan commented Jan 10, 2024

situchan commented Jan 10, 2024

situchan left a comment

situchan commented Jan 10, 2024

OSBotify commented Jan 10, 2024

roryabraham commented Jan 10, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

AutoscrollToTopThreshold #34244

AutoscrollToTopThreshold #34244

Conversation

perunt commented Jan 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 10, 2024

roryabraham commented Jan 10, 2024

roryabraham commented Jan 10, 2024

situchan commented Jan 10, 2024

QA Steps

situchan commented Jan 10, 2024

situchan commented Jan 10, 2024

situchan commented Jan 10, 2024

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

situchan commented Jan 10, 2024

OSBotify commented Jan 10, 2024

roryabraham commented Jan 10, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

`AutoscrollToTopThreshold` #34244

`AutoscrollToTopThreshold` #34244

perunt commented Jan 10, 2024 •

edited

Loading