Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display receipts in chat #24235
Display receipts in chat #24235
Changes from 48 commits
a3b0dd2
f143e1f
04d0c3b
7466501
941d730
cf4680f
f0ced3a
e695401
4ae0c89
5140fed
4177c40
3f7acbe
0f25a34
d97b3bb
fb4120e
b6280f2
a7fe6c8
3a1cd71
1c98982
b2b9529
2c9768f
570a5da
904edce
ca2efcd
2d2e584
b2ae453
ee8e83d
acb2956
5d61c87
2189b1e
c039cd3
b20f2a5
12536f9
3c2a7b7
2fcf052
64e5b37
4aee47b
60af804
143c780
4f2726a
02086e0
6d026dd
eb96c58
2fe3b2b
9ea46f9
a87ddcf
739c315
ecd553b
a5b6dff
b28d952
6c8be71
25c91a0
34ab456
69b1e8f
5155857
cc483cc
7687d7f
4788324
dec55b4
5875061
55a66a3
daa7e85
e057aca
aad1961
b12644c
fec32bf
c63f160
de09a89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a global change, is this really needed? Can we use the w100 and h100 just for the instance where it's actually required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is easily doable without refactoring a lot of ReportActionItemImage's use of RenderHTML. I can do this in a followup PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line that causes #25678 unfortunately, can we think of a way to update it without refactoring everything else?