Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #13174 to staging 🍒 #13176

Merged
merged 2 commits into from
Nov 30, 2022
Merged

🍒 Cherry pick PR #13174 to staging 🍒 #13176

merged 2 commits into from
Nov 30, 2022

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #13174 to staging 🍒

OSBotify and others added 2 commits November 30, 2022 01:48
@OSBotify
Merge pull request #13175 from Expensify/version-BUILD-80F4712F-9F05-…
2389d4c 
…4E4C-9E1E-E2F6049B39E1

Update version to 1.2.33-7 on main

(cherry picked from commit 3788887)
@luacmartins @OSBotify
Merge pull request #13174 from Expensify/rocio-BackgroundColor
a5dde73 
Add a color to the options in the picker when using Windows

(cherry picked from commit df97c3c)
@OSBotify OSBotify requested a review from a team as a code owner November 30, 2022 01:48
@melvin-bot melvin-bot bot removed the request for review from a team November 30, 2022 01:48
@melvin-bot
Copy link

melvin-bot bot commented Nov 30, 2022

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@OSBotify OSBotify merged commit dd80701 into staging Nov 30, 2022
@OSBotify OSBotify deleted the OSBotify-cherry-pick-staging-13174 branch November 30, 2022 01:48
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by @OSBotify in version: 1.2.33-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OSBotify @luacmartins