Fix multiple options getting selected on `SearchPage`, `NewGroupPage` #12906

jasperhuangg · 2022-11-21T22:19:48Z

The indexOffset for each section passed to a SectionList is supposed to equal the total number of items in all the previous sections. We weren't updating it correctly each time we added options to a section, which was causing multiple options to be highlighted.

This also simplifies the logic used to calculate indexOffset and makes it more legible so people don't mess up calculating it next time.

Fixed Issues

$ #12900

Tests/QA

Search Page

Create an account that contains some numbers i.e. 1122334455@test.com
Sign into a different account. On the search page (<Command+K> to open), enter a few numbers (not all) in the email (i.e. 22)
Verify that only the first option is highlighted:

New Group Page

Create an account that contains some numbers i.e. 1122334455@test.com
Sign into a different account. In the new group page (<Command+Shift+K> to open), enter a few numbers (not all) in the email (i.e. 22)
Verify that only the first option is highlighted:

Offline tests

N/A

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

web.mov

Mobile Web - Chrome

android-chrome.mov

Mobile Web - Safari

ios-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2022-11-21T22:37:18Z

@rushatgabhane @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ffsetUsage

src/pages/SearchPage.js

…rToInvite

src/pages/NewChatPage.js

jasperhuangg · 2022-11-22T15:56:24Z

@rushatgabhane good for another look, thanks for the review!

rushatgabhane

@grgia PR looks great to me ✨

PR review checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane · 2022-11-22T17:47:24Z

P.S. no idea why reviewer checklist test is failing. There is no diff

grgia · 2022-11-22T18:16:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

grgia · 2022-11-22T18:18:50Z

@rushatgabhane I think we need to remove the details/summary tag to get it to pass. It's been a bit flakey this week

grgia

nice fix!

OSBotify · 2022-11-22T18:27:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-24T00:52:04Z

🚀 Deployed to staging by @grgia in version: 1.2.31-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2022-12-06T17:37:07Z

The production deploy comment failed for this PR, but this was deployed to production on v1.2.32-2 on Nov 28.

fix indexOffset usage

1e079e6

jasperhuangg self-assigned this Nov 21, 2022

jasperhuangg changed the title ~~Sum indexOffset correctly when creating sections for SectionList~~ Sum indexOffset correctly when creating sections for SectionList in getSections Nov 21, 2022

jasperhuangg marked this pull request as ready for review November 21, 2022 22:36

jasperhuangg requested a review from a team as a code owner November 21, 2022 22:36

melvin-bot bot requested review from grgia and rushatgabhane and removed request for a team November 21, 2022 22:37

Merge branch 'main' of github.com:Expensify/App into jasper-fixIndexO…

d373767

…ffsetUsage

jasperhuangg changed the title ~~Sum indexOffset correctly when creating sections for SectionList in getSections~~ Sum indexOffset correctly when creating sections for SectionList on SearchPage Nov 21, 2022

rushatgabhane reviewed Nov 22, 2022

View reviewed changes

src/pages/SearchPage.js Show resolved Hide resolved

less operations to calculate indexOffset, calculate correctly for use…

d2db3cc

…rToInvite

jasperhuangg commented Nov 22, 2022

View reviewed changes

src/pages/NewChatPage.js Show resolved Hide resolved

fix indexOffset for WorkspaceInvitePage

2e07f0d

jasperhuangg changed the title ~~Sum indexOffset correctly when creating sections for SectionList on SearchPage~~ Fix multiple options getting selected on SearchPage, NewGroupPage, and WorkspaceInvitePage` Nov 22, 2022

jasperhuangg changed the title ~~Fix multiple options getting selected on SearchPage, NewGroupPage, and WorkspaceInvitePage`~~ Fix multiple options getting selected on SearchPage, NewGroupPage, and WorkspaceInvitePage Nov 22, 2022

jasperhuangg added 8 commits November 22, 2022 07:19

revert unused

137744e

revert unused

50cf409

revert unused

33d63ac

add comment explaining hard-coded indexOffset

7d010f2

refactor indexOffset calculation

2c4b5ca

whitespace

767b4e7

whitespace

738410d

remove unused comment

d8eb4c6

jasperhuangg changed the title ~~Fix multiple options getting selected on SearchPage, NewGroupPage, and WorkspaceInvitePage~~ Fix multiple options getting selected on SearchPage, NewGroupPage Nov 22, 2022

jasperhuangg requested a review from rushatgabhane November 22, 2022 15:31

remove unused comments

3ff03f8

rushatgabhane approved these changes Nov 22, 2022

View reviewed changes

grgia approved these changes Nov 22, 2022

View reviewed changes

grgia merged commit 2c558de into main Nov 22, 2022

grgia deleted the jasper-fixIndexOffsetUsage branch November 22, 2022 18:22

OSBotify mentioned this pull request Nov 23, 2022

Deploy Checklist: New Expensify 2022-11-23 #12976

Closed

38 tasks

melvin-bot bot mentioned this pull request Nov 25, 2022

[HOLD for payment 2022-12-02] New Chat - When a username has numbers, multiple names are highlighted in the search #12900

Closed

jasperhuangg mentioned this pull request Dec 2, 2022

fix: Search Page Order #6971

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix multiple options getting selected on `SearchPage`, `NewGroupPage` #12906

Fix multiple options getting selected on `SearchPage`, `NewGroupPage` #12906

jasperhuangg commented Nov 21, 2022 •

edited

Loading

melvin-bot bot commented Nov 21, 2022

jasperhuangg commented Nov 22, 2022

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Nov 22, 2022 •

edited

Loading

grgia commented Nov 22, 2022 •

edited

Loading

grgia commented Nov 22, 2022

grgia left a comment

OSBotify commented Nov 22, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

Fix multiple options getting selected on SearchPage, NewGroupPage #12906

Fix multiple options getting selected on SearchPage, NewGroupPage #12906

Conversation

jasperhuangg commented Nov 21, 2022 • edited Loading

Fixed Issues

Tests/QA

Search Page

New Group Page

Offline tests

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot bot commented Nov 21, 2022

jasperhuangg commented Nov 22, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

rushatgabhane commented Nov 22, 2022 • edited Loading

grgia commented Nov 22, 2022 • edited Loading

Reviewer Checklist

grgia commented Nov 22, 2022

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 22, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

Fix multiple options getting selected on `SearchPage`, `NewGroupPage` #12906

Fix multiple options getting selected on `SearchPage`, `NewGroupPage` #12906

jasperhuangg commented Nov 21, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Nov 22, 2022 •

edited

Loading

grgia commented Nov 22, 2022 •

edited

Loading