Reconciliation tab missing total amounts

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.10‑6
Reproducible in staging?: Needs Reproduction (Reproduction blocked)
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @scerrato88
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Go to Reports → Reconciliation
2. Filter by Card → Expensify Cards
3. Set Date: Dec 30th – Jan 30th (or any date range with transactions)
4. Check the bottom of the UI for total amounts

Expected Result:

Total amount summary is displayed (e.g., at the bottom right of the UI), matching Expensify Classic behavior.

Actual Result:

No total amount is displayed anywhere on the Reconciliation tab.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

The screenshot for the issue is in slack thread

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ShridharGoel

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ShridharGoel (External)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When users navigate to Reports -> Reconciliation and apply filters (like date range or card filters), the total amount summary that should appear at the bottom of the UI is missing.

What is the root cause of that problem?

The issue is in how useSearchShouldCalculateTotals determines whether to request totals from the backend. The hook relies on matching the current search's similarSearchHash to a predefined suggested search to derive the searchKey. When the user modifies filters (like changing the date range or adding a card filter), the similarSearchHash changes, causing searchKey to become undefined. Since searchKey is no longer 'reconciliation', the hook returns false and totals are never requested.

App/src/hooks/useSearchShouldCalculateTotals.ts

Lines 31 to 35 in 2e06607

	];
	if (eligibleSearchKeys.includes(searchKey)) {
	return true;
	}

The hook correctly includes RECONCILIATION in the eligible keys, but that check only works when searchKey matches exactly. Once filters are modified, the search is still fundamentally a reconciliation search (grouped by withdrawal ID), but the hook no longer recognizes it as such.

What changes do you think we should make in order to solve the problem?

The fix is to update useSearchShouldCalculateTotals to also check if the search is grouped by WITHDRAWAL_ID, which is the defining characteristic of a reconciliation search. This way, even when filters are modified, the totals will still be calculated as long as the search maintains its reconciliation structure.

- function useSearchShouldCalculateTotals(searchKey: SearchKey | undefined, similarSearchHash: number | undefined, enabled: boolean) {
+ function useSearchShouldCalculateTotals(searchKey: SearchKey | undefined, similarSearchHash: number | undefined, enabled: boolean, groupBy?: string) {
     const [savedSearches] = useOnyx(ONYXKEYS.SAVED_SEARCHES, {canBeMissing: true});

     const shouldCalculateTotals = useMemo(() => {
         if (!enabled) {
             return false;
         }

         const savedSearchValues = Object.values(savedSearches ?? {});

-        if (!savedSearchValues.length && !searchKey) {
+        if (!savedSearchValues.length && !searchKey && !groupBy) {
             return false;
         }

+        // Reconciliation searches are grouped by withdrawal ID - always calculate totals for these
+        if (groupBy === CONST.SEARCH.GROUP_BY.WITHDRAWAL_ID) {
+            return true;
+        }
+
         const eligibleSearchKeys: Partial<SearchKey[]> = [
             CONST.SEARCH.SEARCH_KEYS.SUBMIT,

The callers in Search/index.tsx and MoneyReportHeader.tsx would pass queryJSON.groupBy as the fourth argument, making the hook aware of the search's grouping structure.

What alternative solutions did you explore? (Optional)

N/A