Expensify card - Expensify Card setup page blinks the first time the Copilot user visits it

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.93-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5543592
Email or phone of affected tester (no customers): applausetester+ag3101c@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Workspace Settings

Action Performed:

Setup:

1. Navigate to account settings
2. Add a copilot with limited access to the account
3. Complete the copilot flow

Steps:

1. Login as the copilot of the admin
2. Go to Expensify Cards Section in the workspace

Expected Result:

The Copilot user leads directly to the Expensify Card page with the list of cards or the empty list.

Actual Result:

The Expensify Card setup page blinks the first time the Copilot user visits it.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

@mountiny @allgandalf @DylanDylann @koko57 is this down to the timing of when we check for permission to access the Expensify Card page? I wonder if we can do that earlier when we open the initial workspace settings page or something?

[mountiny]

I guess we would need to load the card data but at the same time its weird it would not happen for a first time visiting the page as admin.

[mountiny]

It feels very minor to me, it only happens the first time and its just a blink, do you think we need to act on this?

[trjExpensify]

I guess we would need to load the card data

If we're loading data, we should use a skeleton loader or something then I think?

[mountiny]

If we're loading data, we should use a skeleton loader or something then I think?

Then we would show the skeleton all the time though - if the user does not have the cards enabled, its same as if its loading as they wont have the private_expensifyCardSettings set so then we cannot distinguish if its loading or thye just not setup

So either we show the section like this or we always show the skeleton - that is everytime you would open it and you dont have the cards set up there will be skeleton to start

[trjExpensify]

we cannot distinguish if its loading or thye just not setup

That seems strange to me. There's a distinct difference between "we're loading the data on this page" and "You haven't set up the Expensify Card".

[koko57]

I can look into this today

[DylanDylann]

this bug is not only happening for copilot users. It always happens in the first time we go to the Expensify Card Page. Due to OpenPolicyExpensifyCardsPage being called only users go to Expensify Card and the empty page will be displayed while waiting for the response from OpenPolicyExpensifyCardsPage API.

@koko57 IMO, we can consider displaying a loading spinner while waiting for OpenPolicyExpensifyCardsPage API

[koko57]

We actually have the spinner implemented I need to check out why it's not being displayed